Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13497#discussion_r65773920
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java ---
    @@ -43,6 +43,8 @@
         RUNNING(false),
         /** The application finished with a successful status. */
         FINISHED(true),
    +    /** The Spark Submit JVM got killed with a unknown status. */
    +    FINISHED_UNKNOWN(true),
    --- End diff --
    
    This should be declared after existing constants, since declaring it here 
will change the `ordinal()` value of existing constants, which is a binary 
compatibility issue. A better name would be good also; maybe "LOST" or 
"DISCONNECTED"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to