Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13497#discussion_r65775002
--- Diff:
launcher/src/test/java/org/apache/spark/launcher/LauncherServerSuite.java ---
@@ -152,6 +175,102 @@ public void testTimeout() throws Exception {
}
}
+ @Test
+ public void testSparkSubmitVmShutsDown() throws Exception {
--- End diff --
This test looks very complicated. Why not:
- create a server and a client that connects to it
- initiate the connection (send "Hello")
- close the client socket
- verify the server socket fires the expected event
This would be very similar to `testCommunication` above until about L112.
After that you just close the client socket and wait for the event on the
handle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
