Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/13603#discussion_r67774823
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -96,22 +120,13 @@ class TaskSchedulerImplSuite extends SparkFunSuite
with LocalSparkContext with L
taskDescriptions =
taskScheduler.resourceOffers(multiCoreWorkerOffers).flatten
assert(1 === taskDescriptions.length)
assert("executor0" === taskDescriptions(0).executorId)
+ assert(!failedTaskSet)
}
test("Scheduler does not crash when tasks are not serializable") {
- sc = new SparkContext("local", "TaskSchedulerImplSuite")
--- End diff --
I agree that this looks completely wrong, and that (1) resourceOffers
should mark a new executor as available more times, not just when a new host is
available -- and this means the HDFS cache locality hasn't been working when
folks have multiple executors and (2) resourceOffers, and not
resourceOffersSingleTaskSet, should add the executor to executorsByHost. Do
you have time to file a JIRA / fix this? Seems like a quick fix, and would be
nice to do before this PR, because of this weird failure (which seems like
something that will be user-visible, since I'm guessing it's not uncommon, for
new users, that their first task isn't serializable).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
