Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13603#discussion_r67775656
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
    @@ -27,18 +29,48 @@ class FakeSchedulerBackend extends SchedulerBackend {
       def defaultParallelism(): Int = 1
     }
     
    -class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext 
with Logging {
    +class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext 
with BeforeAndAfterEach
    +    with Logging {
     
    -  test("Scheduler does not always schedule tasks on the same workers") {
    +
    +  var failedTaskSetExc: Option[Throwable] = None
    +  var failedTaskSetReason: String = null
    +  var failedTaskSet = false
    +
    +  override def beforeEach(): Unit = {
    +    super.beforeEach()
    +    failedTaskSet = false
    +    failedTaskSetExc = None
    +    failedTaskSetReason = null
    +  }
    +
    +  def setupScheduler(confs: (String, String)*): TaskSchedulerImpl = {
    --- End diff --
    
    👍  for eliminating this redundancy


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to