Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/2078#issuecomment-52960988
Regarding logging -
host:port is insufficient to debug (and as I mentioned above, you will get
NPE for the log messages in this PR depending on the key's state) - you
actually need the key instance correlated across log messages to debug issues.
To find host:port for a key, it is logged elsewhere in the code iirc (and
we grep by instance id).
Regarding changes to try/catch, etc : it looks regressive - we spent quite
a while making this class reasonably bugfree early last year - I have not kept
up to date with modifications to this class, but this PR will break
functionality,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
