Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2078#issuecomment-53149962
> Regarding logging -
> host:port is insufficient to debug (and as I mentioned above, you will
get NPE for the log messages in > this PR depending on the key's state) - you
actually need the key instance correlated across log messages to debug issues.
> To find host:port for a key, it is logged elsewhere in the code iirc (and
we grep by instance id).
Is this true? I cannot found log message which shows the key and
corresponding host:port.
In ConnectionManager, when accepting connection and connecting to another
host, host:port is logged so logging host:port when error occurred is helpful.
Even if we can found host:port for a key, I think, it's good to be able to
find host:port directly.
I think, "be able to debug" is not "easy to debug".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
