Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2078#issuecomment-53154553
I don't mind handling NPE but I wonder why / where / how NPE is thrown.
At least, JavaDoc doesn't say SelectionKey#channel, SocketChannel#socket
return null.
And after key is cancelled, key.channel still return non-null object.
And I found, the bug of throwing CancelledKeyException may be for MacOSX.
https://java.net/projects/macosx-port/lists/issues/archive/2011-10/message/186
O.K. I agree to leave try / catch but I think, we should leave comment why
select should be enclosed try block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
