Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/1964#issuecomment-53006322
Hello @erikerlandson,
Thank you for your comment.
Its' in the morning in Japan :)
> I don't think a Weighted trait improves the design.
I agree with you. I removed Weighted trait.
> Given how small these classes are, it seems like it would be efficient to
define them all in a single file
I moved the definitions of classes to DistanceMeassure or DistanceMetric.
Sorry to trouble you.Would you please review it.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
