Github user srowen commented on a diff in the pull request:
    --- Diff: 
mllib/src/test/scala/org/apache/spark/mllib/feature/Word2VecSuite.scala ---
    @@ -68,6 +69,21 @@ class Word2VecSuite extends SparkFunSuite with 
MLlibTestSparkContext {
         assert(syms(1)._1 == "japan")
    +  test("findSynonyms doesn't reject similar word vectors when called with 
a vector") {
    +    val num = 2
    +    val word2VecMap = Map(
    +      ("china", Array(0.50f, 0.50f, 0.50f, 0.50f)),
    +      ("japan", Array(0.40f, 0.50f, 0.50f, 0.50f)),
    +      ("taiwan", Array(0.60f, 0.50f, 0.50f, 0.50f)),
    +      ("korea", Array(0.45f, 0.60f, 0.60f, 0.60f))
    +    )
    +    val model = new Word2VecModel(word2VecMap)
    +    val syms = model.findSynonyms(Vectors.dense(Array(0.52d, 0.50d, 0.50d, 
0.50d)), num)
    --- End diff --
    Nit, but I think "d" is redundant. Also "0.5" seems clearer than "0.50" but 
this is truly up to taste.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to