Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r78995496
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
wordList.zip(cosVec)
.toSeq
.sortBy(-_._2)
- .take(num + 1)
- .tail
+ .filter(tup => wordOpt.map(w => !w.equals(tup._1)).getOrElse(true)
&& tup._2 != 1.0d)
--- End diff --
@srowen So actually reverting to the old code but filtering only if
`wordOpt` is defined doesn't handle the original case I was considering here,
where you pass in a vector that is very similar to the representation of a word
in the vocabulary but that is not itself the representation of a word in the
vocabulary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
