Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r78981066
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
wordList.zip(cosVec)
.toSeq
.sortBy(-_._2)
- .take(num + 1)
- .tail
+ .filter(tup => wordOpt.map(w => !w.equals(tup._1)).getOrElse(true)
&& tup._2 != 1.0d)
--- End diff --
@srowen This code in general kind of bothers me (I'd rather see a single
pass through the tuples with a bounded priority queue keeping track of the `num
+ 1` candidates than converting to a sequence and then allocating an array to
sort in place). But I'm inclined to get some numbers showing that that is a
good idea and make it a separate PR unless this is a good time to fold it in
(so to speak).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
