Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r79006879
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
wordList.zip(cosVec)
.toSeq
.sortBy(-_._2)
- .take(num + 1)
- .tail
+ .filter(tup => wordOpt.map(w => !w.equals(tup._1)).getOrElse(true)
&& tup._2 != 1.0d)
--- End diff --
Oops, "tail" is wrong, yeah, because it would give you the bottom n out of
n+1, when you just want the first n out of the n+1. Otherwise I think this
works?
Anyway, agree with the change you propose. If specifying a vector I would
not expect any filtering of the first element. We're changing the behavior no
matter what here but it's a fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
