Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15046#discussion_r79481517 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -318,24 +319,28 @@ case class DataSource( */ def resolveRelation(): BaseRelation = { val caseInsensitiveOptions = new CaseInsensitiveMap(options) - val relation = (providingClass.newInstance(), userSpecifiedSchema) match { + val relation = (providingClass.newInstance(), inputSchema) match { // TODO: Throw when too much is given. case (dataSource: SchemaRelationProvider, Some(schema)) => dataSource.createRelation(sparkSession.sqlContext, caseInsensitiveOptions, schema) case (dataSource: RelationProvider, None) => dataSource.createRelation(sparkSession.sqlContext, caseInsensitiveOptions) case (_: SchemaRelationProvider, None) => throw new AnalysisException(s"A schema needs to be specified when using $className.") - case (_: RelationProvider, Some(_)) => - throw new AnalysisException(s"$className does not allow user-specified schemas.") + case (dataSource: RelationProvider, Some(_)) => + if (isSchemaFromUsers) { + throw new AnalysisException(s"$className does not allow user-specified schemas.") + } else { + dataSource.createRelation(sparkSession.sqlContext, caseInsensitiveOptions) --- End diff -- Yeah, this is a pretty good idea. Let me try it. Thanks!
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org