Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15046#discussion_r79533310
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ---
    @@ -327,8 +327,13 @@ case class DataSource(
             dataSource.createRelation(sparkSession.sqlContext, 
caseInsensitiveOptions)
           case (_: SchemaRelationProvider, None) =>
             throw new AnalysisException(s"A schema needs to be specified when 
using $className.")
    -      case (_: RelationProvider, Some(_)) =>
    -        throw new AnalysisException(s"$className does not allow 
user-specified schemas.")
    +      case (dataSource: RelationProvider, Some(schema)) =>
    +        val baseRelation =
    +          dataSource.createRelation(sparkSession.sqlContext, 
caseInsensitiveOptions)
    +        if (baseRelation.schema != schema) {
    --- End diff --
    
    cc @yhuai @liancheng to confirm, is it safe?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to