Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15046#discussion_r79721868
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/sources/TableScanSuite.scala ---
    @@ -345,34 +345,72 @@ class TableScanSuite extends DataSourceTest with 
SharedSQLContext {
           (1 to 10).map(Row(_)).toSeq)
       }
     
    +  test("create a temp table that does not have a path in the option") {
    +    Seq("TEMPORARY VIEW", "TABLE").foreach { tableType =>
    +      val tableName = "relationProvierWithSchema"
    +      withTable(tableName) {
    +        sql(
    +          s"""
    +             |CREATE $tableType $tableName
    --- End diff --
    
    My original thought is to provide a comprehensive test coverage of data 
source table creation/insertion with `path`. This is not related to this PR. 
Let me get rid of it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to