Github user HyukjinKwon commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1426,7 +1426,7 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
        * supported for Hadoop-supported filesystems.
       def addFile(path: String, recursive: Boolean): Unit = {
    -    val uri = new URI(path)
    +    val uri = new Path(path).toUri
    --- End diff --
    I do understand your concern @felixcheung. However,  IMHO, it'd be okay to 
not test Hadoop library within Spark. I will try to find some 
tests/documentation related with Windows path and then will share to make sure.
    FWIW, this case was verified by one of comitters before for Windows path. 
So, it'd be okay.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to