Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15131#discussion_r79732092
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1457,8 +1457,8 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
           logInfo(s"Added file $path at $key with timestamp $timestamp")
           // Fetch the file locally so that closures which are run on the 
driver can still use the
           // SparkFiles API to access files.
    -      Utils.fetchFile(path, new File(SparkFiles.getRootDirectory()), conf, 
env.securityManager,
    -        hadoopConfiguration, timestamp, useCache = false)
    +      Utils.fetchFile(uri.toString, new 
File(SparkFiles.getRootDirectory()), conf,
    --- End diff --
    
    In my peraonal opinion, I thought it's okay (I thought about this for a 
while) because `Utils.fetchFile` wants the first argument as url not path. So, 
this might be a valid correction without tests because we fixed the argument to 
what the function initially wants. But no strong opinion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to