Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/2078#issuecomment-53184900
Sounds good, tux !
On 24-Aug-2014 2:28 pm, "Kousuke Saruta" <notificati...@github.com> wrote:
> Thanks @mridulm <https://github.com/mridulm> , @JoshRosen
> <https://github.com/JoshRosen> !
> So, how about the solution as follows?
>
> - Leave try / catch for CancelledKeyException which can be thrown from
> selector.select()
> - Separate function to get the pair of remote address and key from
> logging statements.
> - Just in case, protect the logic to get remote address for NPE.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/2078#issuecomment-53184688>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
