Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2078#issuecomment-53176045
My initial thoughts: the ConnectionManager is a complex piece of code
that's been the source of many bugs, so I'd like to be conservative when it
comes to changing it.
If there's even a slight chance that the `CancelledKeyException` might be
thrown, even if it's due to a platform bug, I'd like to keep the code that
c3a4bc3ae0fe04d1f40848e9ac8169f264e43880 removed.
I like @mridulm's suggestion of making a separate helper function for this
logging. Feel free to summarize some of this discussion in comments, too,
including the rationale for why remoteAddress won't NPE (if it was complicated
enough to provoke this much discussion, then it's worth documenting).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
