Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15152#discussion_r79886506
  
    --- Diff: 
core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala ---
    @@ -263,6 +266,55 @@ class ExecutorAllocationManagerSuite
         assert(executorsPendingToRemove(manager).isEmpty)
       }
     
    +  test("remove multiple executors") {
    +    sc = createSparkContext(5, 10, 5)
    +    val manager = sc.executorAllocationManager.get
    +    (1 to 10).map(_.toString).foreach { id => onExecutorAdded(manager, id) 
}
    +
    +    // Keep removing until the limit is reached
    +    assert(executorsPendingToRemove(manager).isEmpty)
    +    assert(removeExecutors(manager, Seq("1")) == Seq("1"))
    --- End diff --
    
    Use `===` in all these.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to