Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15152#discussion_r79886961
  
    --- Diff: 
core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala ---
    @@ -1040,3 +1094,62 @@ private object ExecutorAllocationManagerSuite 
extends PrivateMethodTester {
         manager invokePrivate _hostToLocalTaskCount()
       }
     }
    +
    +/**
    + * A cluster manager which wraps around the scheduler and backend for 
local mode. It is used for
    + * testing the dynamic allocation policy.
    + */
    +private class DummyLocalExternalClusterManager extends 
ExternalClusterManager {
    +
    +  def canCreate(masterURL: String): Boolean = masterURL == 
"myDummyLocalExternalClusterManager"
    +
    +  override def createTaskScheduler(sc: SparkContext,
    --- End diff --
    
    style: 
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide#SparkCodeStyleGuide-Indentation
    
    Each parameter on a separate line when breaking. Happens in a bunch of 
methods here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to