Github user dhruve commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15152#discussion_r79889574
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
    @@ -54,13 +54,16 @@ private[spark] trait ExecutorAllocationClient {
     
       /**
        * Request that the cluster manager kill the specified executors.
    -   * @return whether the request is acknowledged by the cluster manager.
    +   * @return the ids of the executors acknowledged by the cluster manager 
to be removed.
        */
    -  def killExecutors(executorIds: Seq[String]): Boolean
    +  def killExecutors(executorIds: Seq[String]): Seq[String]
     
       /**
        * Request that the cluster manager kill the specified executor.
        * @return whether the request is acknowledged by the cluster manager.
        */
    -  def killExecutor(executorId: String): Boolean = 
killExecutors(Seq(executorId))
    +  def killExecutor(executorId: String): Boolean = {
    +    val killedExecutors = killExecutors(Seq(executorId))
    +    killedExecutors.nonEmpty && killedExecutors(0).equals(executorId)
    --- End diff --
    
    It doesn't. Just added an additional check here to be sure. I need to 
change the short circuit operator here to &.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to