Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1717#issuecomment-53217871
@sjbrunst This is great addition! Thanks for the effort. However, from the
patch, I can see that this changes the signature of a few methods, which
required the examples to be changed. This is not desirable as we want to
maintain binary compatibility as much as possible across different Spark
versions. So I strongly suggest that the existing methods in TwitterUtils not
be touched and new methods with the new location parameter by added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
