Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1717#discussion_r16639413
  
    --- Diff: 
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterUtils.scala
 ---
    @@ -33,15 +33,20 @@ object TwitterUtils {
        *        twitter4j.oauth.consumerSecret, twitter4j.oauth.accessToken and
        *        twitter4j.oauth.accessTokenSecret
        * @param filters Set of filter strings to get only those tweets that 
match them
    +   * @param locations Set of longitude and latitude coordinates to get 
only those tweets within the
    +            bounding box defined by those points. Example: 
Seq(Seq(-180.0,-90.0),Seq(180.0,90.0))
    +            gives any geotagged tweet. If locations and filters are both 
nonempty, then any tweet
    +            matching either condition may be returned.
        * @param storageLevel Storage level to use for storing the received 
objects
        */
       def createStream(
           ssc: StreamingContext,
           twitterAuth: Option[Authorization],
           filters: Seq[String] = Nil,
    +      locations: Seq[Seq[Double]] = Nil,
    --- End diff --
    
    This changes method signature, probably not binary compatible. Please added 
a new method and leave this method untouched. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to