Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1717#discussion_r16639523
--- Diff:
external/twitter/src/test/java/org/apache/spark/streaming/twitter/JavaTwitterStreamSuite.java
---
@@ -31,16 +31,19 @@
@Test
public void testTwitterStream() {
String[] filters = (String[])Arrays.<String>asList("filter1",
"filter2").toArray();
+ double[][] locations = {{-180.0,-90.0},{180.0,90.0}};
Authorization auth = NullAuthorization.getInstance();
// tests the API, does not actually test data receiving
JavaDStream<Status> test1 = TwitterUtils.createStream(ssc);
JavaDStream<Status> test2 = TwitterUtils.createStream(ssc, filters);
- JavaDStream<Status> test3 = TwitterUtils.createStream(
- ssc, filters, StorageLevel.MEMORY_AND_DISK_SER_2());
- JavaDStream<Status> test4 = TwitterUtils.createStream(ssc, auth);
- JavaDStream<Status> test5 = TwitterUtils.createStream(ssc, auth,
filters);
- JavaDStream<Status> test6 = TwitterUtils.createStream(ssc,
- auth, filters, StorageLevel.MEMORY_AND_DISK_SER_2());
+ JavaDStream<Status> test3 = TwitterUtils.createStream(ssc, filters,
locations);
--- End diff --
These tests, should not have to be deleted if signatures are not changed.
Only new tests should be added to account for the new signature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
