Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/spark/pull/15248#discussion_r80754121
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -178,6 +178,23 @@ class HistoryServer(
provider.getListing()
}
+ /**
+ * Returns a list of available applications, in descending order
according to their end time.
+ *
+ * @param limit the number of applications to return
+ * @return List of known applications with a limit.
+ */
+ def getApplicationInfoList(limit: Int): Iterator[ApplicationInfo] = {
--- End diff --
Actually I think it is better to add a default value here indicating
unlimited so that the following method can be totally removed
def getApplicationInfoList: Iterator[ApplicationInfo]
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
