Github user ajbozarth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15248#discussion_r80795551
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/api/v1/ApiRootResource.scala ---
    @@ -222,6 +222,7 @@ private[spark] object ApiRootResource {
     private[spark] trait UIRoot {
       def getSparkUI(appKey: String): Option[SparkUI]
       def getApplicationInfoList: Iterator[ApplicationInfo]
    +  def getApplicationInfoList(limit: Int): Iterator[ApplicationInfo]
    --- End diff --
    
    1. The null check occurs at the endpoint though so it doesn't affect this 
function. 
    2. take(-1) and take(0) don't return the same thing, any negative input to 
take returns the whole list, this was checked in my previous pr and it is the 
default value in `historypage.js` 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to