Github user ajbozarth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15248#discussion_r80807429
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/api/v1/ApplicationListResource.scala
 ---
    @@ -42,7 +44,7 @@ private[v1] class ApplicationListResource(uiRoot: UIRoot) 
{
         }
         val includeCompleted = adjStatus.contains(ApplicationStatus.COMPLETED)
         val includeRunning = adjStatus.contains(ApplicationStatus.RUNNING)
    -    val appList = allApps.filter { app =>
    +    allApps.filter { app =>
    --- End diff --
    
    So I've just realized a fundamental issue with this code change. This 
filter is being done *after* the limit now. This mean if you limit to say 100 
app but set the date to a year ago you'd expect 100 apps from a year ago, but 
this instead will return apps from a year ago from the last 100 apps, which for 
a busy server would be 0. 
    This means the limit *must* be run after this filter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to