Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/spark/pull/15248#discussion_r80818667
--- Diff:
core/src/main/scala/org/apache/spark/status/api/v1/ApplicationListResource.scala
---
@@ -42,7 +44,7 @@ private[v1] class ApplicationListResource(uiRoot: UIRoot)
{
}
val includeCompleted = adjStatus.contains(ApplicationStatus.COMPLETED)
val includeRunning = adjStatus.contains(ApplicationStatus.RUNNING)
- val appList = allApps.filter { app =>
+ allApps.filter { app =>
--- End diff --
Yup I missed that part. Very good suggestion.
Now I've made changes to return a view of the list so that we can filter at
first and then take the limit. The previous getApplicationInfoList remains
unchanged.
Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
