Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1843#discussion_r16722717
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -68,7 +68,26 @@ class SparkHadoopUtil extends Logging {
* Return an appropriate (subclass) of Configuration. Creating config
can initializes some Hadoop
* subsystems.
*/
- def newConfiguration(): Configuration = new Configuration()
+ def newConfiguration(conf: SparkConf): Configuration = {
--- End diff --
I know the whole "deploy" package is excluded from mima checks (because I
added the exclude at @pwendell's request). How is it documented that these
packages are "private", if at all? Do we need explicit annotations in that case?
(http://spark.apache.org/docs/1.0.0/api/scala/#package does not list the
package, so maybe that's it?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
