Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1843#discussion_r16751825
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -68,7 +68,26 @@ class SparkHadoopUtil extends Logging {
* Return an appropriate (subclass) of Configuration. Creating config
can initializes some Hadoop
* subsystems.
*/
- def newConfiguration(): Configuration = new Configuration()
+ def newConfiguration(conf: SparkConf): Configuration = {
--- End diff --
It's the same as the rest of the codebase -- everything that is "private"
should be marked `private[spark]`. Things that we need to make public for
advanced developers are `@DeveloperApi`. In this case, this thing has been
public so we can't remove it, but we could at least mark it to tell people not
to depend on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
