Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15497#discussion_r83584305
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryListenerSuite.scala
 ---
    @@ -81,7 +81,7 @@ class StreamingQueryListenerSuite extends StreamTest with 
BeforeAndAfter {
           AssertOnLastQueryStatus { status: StreamingQueryStatus =>
             // Check the correctness of the trigger info of the last completed 
batch reported by
             // onQueryProgress
    -        assert(status.triggerDetails.get("triggerId") == "0")
    +        assert(Seq("-1", 
"0").contains(status.triggerDetails.get("triggerId")))
    --- End diff --
    
    Look at my PR, I replaced `.get` with `.containsKey` because all we need to 
test here is that the triggerId key is set. The exact trigger id in which the 
data was found, etc. is not important. 
    
    https://github.com/apache/spark/pull/15492
    
    Could you change this PR to do the same. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to