Github user lw-lin commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/util/ManualClock.scala ---
    @@ -27,6 +27,7 @@ package org.apache.spark.util
     private[spark] class ManualClock(private var time: Long) extends Clock {
       private var _isWaiting = false
    +  private var _readyForFirstPeek = false
    --- End diff --
    This sounds good!
    One thing to confirm: we are assuming only **one** main thread and **one** 
test thread, right? Because:
    - given two main threads m1, m2, and one testing thread t, should 
`isThreadWaitingAt(time)` return true or false if m1 reaches `waitUtil(time)` 
but m2 does not yet?
    - given one main threads m, and two testing threads t1, t2, should 
`isThreadWaitingAt(time)` return true for only one of t1, t2 or both?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to