Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15497#discussion_r83585137
  
    --- Diff: core/src/main/scala/org/apache/spark/util/ManualClock.scala ---
    @@ -27,6 +27,7 @@ package org.apache.spark.util
     private[spark] class ManualClock(private var time: Long) extends Clock {
     
       private var _isWaiting = false
    +  private var _readyForFirstPeek = false
    --- End diff --
    
    I pulled in your current fix into my PR to test for flakiness by running it 
in a loop in Jenkins. At least that will give us confidence that the theory of 
the bug is right. Nonetheless, please change the API and code as I suggested. 
    
    My PR - https://github.com/apache/spark/pull/15492
    See Jenkin builds - 3352, 3353, 3354. Each of them is expected to test 
StreamingQueryListenerSuite about 50 times before Jenkins times out.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to