Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2155#issuecomment-53632983
Thanks for working on this. I'm concerned that in many cases we are
actually changing the semantics here. Instead of replacing places where we use
`id` to just use `==` I think we actually want to be using `eq` and `ne` which
are the scala operations for reference equality (i.e. are these two objects
actually the same object, stored at the same place in memory).
For example:
```scala
scala> case class A(x: Int)
defined class A
scala> val a1 = A(1)
a1: A = A(1)
scala> val a2 = A(1)
a2: A = A(1)
scala> a1 == a2
res0: Boolean = true
scala> a1 eq a2
res1: Boolean = false
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
