Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2155#discussion_r16877237
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/trees/TreeNodeSuite.scala
---
@@ -51,7 +51,6 @@ class TreeNodeSuite extends FunSuite {
val after = before transform { case Literal(5, _) => Literal(1)}
assert(before === after)
- assert(before.map(_.id) === after.map(_.id))
--- End diff --
Instead of deleting this maybe something like:
```scala
before.map(identity[Expression]).zip(after.map(identity[Expression])).foreach {
case (b, a) => assert(b eq a) }
```
Perhaps with a comment: `// Ensure that the object after are the same
objects before the transformation`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
