Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2155#discussion_r16877263
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/package.scala
---
@@ -37,4 +37,15 @@ package object trees extends Logging {
// Since we want tree nodes to be lightweight, we create one logger for
all treenode instances.
protected override def logName = "catalyst.trees"
+ /**
+ * A [[TreeNode]] companion for reference equality for Hash based
Collection.
+ */
+ implicit class TreeNodeRef(val obj: TreeNode[_]) {
--- End diff --
Hm, I see. I think in this case I'd prefer to be a little more verbose. A
general rule is that you should only use implicit conversions to extend
functionality, but never to perform subtle type conversions. These can lead to
really confusing errors when things go wrong. You might be safe here, but I've
used implicits many times counter to this rule and I almost always end up
regretting it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
