Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15212#discussion_r84042250
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
    @@ -72,11 +72,15 @@ private[feature] trait ChiSqSelectorParams extends 
Params
       def getPercentile: Double = $(percentile)
     
       /**
    -   * The highest p-value for features to be kept.
    -   * Only applicable when selectorType = "fpr".
    +   * alpha means the highest p-value for features to be kept when select 
type is "fpr".
    +   * alpha means the highest uncorrected p-value for features to be kept 
when select type
    +   * is "fdr" and "fwe".
        * Default value is 0.05.
        */
    -  final val alpha = new DoubleParam(this, "alpha", "The highest p-value 
for features to be kept.",
    +  final val alpha = new DoubleParam(this, "alpha",
    +    "alpha means the highest p-value for features to be kept when select 
type is fpr, " +
    +      "alpha means the highest uncorrected p-value for features to be kept 
when select type " +
    --- End diff --
    
    ```, or the highest ...```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to