Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15212#discussion_r84043926
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -104,6 +108,9 @@ private[feature] trait ChiSqSelectorParams extends
Params
* `kbest` chooses the `k` top features according to a chi-squared test.
* `percentile` is similar but chooses a fraction of all features instead
of a fixed number.
* `fpr` chooses all features whose false positive rate meets some
threshold.
+ * `fpr` select features based on a false positive rate test.
--- End diff --
This has two lines for fpr. The existing text is more descriptive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
