Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15212#discussion_r84041851 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -72,11 +72,15 @@ private[feature] trait ChiSqSelectorParams extends Params def getPercentile: Double = $(percentile) /** - * The highest p-value for features to be kept. - * Only applicable when selectorType = "fpr". + * alpha means the highest p-value for features to be kept when select type is "fpr". --- End diff -- We should keep ```Only applicable when selectorType = "fpr", "fdr" or "fwe".```, since it's not applicable to other selector types such as "kbest" and "percentile".
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org