Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15567#discussion_r84339070
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
 ---
    @@ -274,12 +274,12 @@ trait Nondeterministic extends Expression {
     
       private[this] var initialized = false
     
    -  final def setInitialValues(): Unit = {
    -    initInternal()
    +  final def initializeStatesForPartition(partitionIndex: Int): Unit = {
    --- End diff --
    
    I don't want to overload the name `initialize`, which is a little vague, 
how about `initStates`? Again, the issue is that even with comments we cannot 
force users to initialize it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to