Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15567#discussion_r84339569
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -185,6 +185,20 @@ class CodegenContext {
       }
     
       /**
    +   * Code statements to initialize states that depend on the partition 
index.
    +   * An integer `partitionIndex` will be made available within the scope.
    +   */
    +  val partitionInitializationStatements: mutable.ArrayBuffer[String] = 
mutable.ArrayBuffer.empty
    +
    +  def addPartitionInitializationStatement(statement: String): Unit = {
    --- End diff --
    
    I'm a little worried about introducing more issues by moving 
`initMutableStates` out from the constructor. The current implementation at 
least maintains the existing behavior if we missed 
`initializeStatesForPartition` somewhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to