Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15567#discussion_r84340783
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GeneratePredicate.scala
 ---
    @@ -25,19 +25,26 @@ import org.apache.spark.sql.catalyst.expressions._
      */
     abstract class Predicate {
       def eval(r: InternalRow): Boolean
    +
    +  /**
    +   * Initialize internal states given the current partition index.
    +   * This is used by non-deterministic expressions to set initial states.
    +   * The default implementation does nothing.
    +   */
    +  def initializeStatesForPartition(partitionIndex: Int): Unit = {}
    --- End diff --
    
    I don't think so, since it is in the interpreted path which is already very 
slow. Also in the normal case the condition will always be false, so CPU branch 
prediction should work its magic.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to