Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84785351
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -710,7 +723,11 @@ object SparkSubmit {
printWarning("Subclasses of scala.App may not work correctly. Use a
main() method instead.")
}
- val mainMethod = mainClass.getMethod("main", new
Array[String](0).getClass)
+ val mainMethod = if (threadEnabled ) {
+ mainClass.getMethods().filter(i => i.getName() == "sparkMain")(0)
--- End diff --
nit: either
`.filter { i => ... }`
or
`.filter(_.getName() == ...)`
Also, theoretically you shouldn't need to use reflection here since you
have a proper type. Scala singletons make this a little more interesting, since
I'm not sure how to get the singleton using reflection, but anyway, this can be
changed later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
