Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84787094
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -110,12 +146,14 @@ private[spark] abstract class LauncherBackend {
override def close(): Unit = {
try {
super.close()
+ if (stopFlag) {
--- End diff --
This seems to be overloading the meaning of `stopFlag`. Does it mean "stop
the app when the launcher goes down", or "stop the app when the launcher is
closed"? This code is implementing the latter, while the earlier shutdown hook
is implementing the former. I don't think the latter is desired in the API;
there is already an explicit API for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
