Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84784981
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -676,8 +678,19 @@ object SparkSubmit {
addJarToClasspath(jar, loader)
}
- for ((key, value) <- sysProps) {
- System.setProperty(key, value)
+ val threadEnabled =
sysProps.getOrElse("spark.launcher.internal.launcher.thread.enabled",
+ "false").toBoolean
+ if (!threadEnabled) {
+ for ((key, value) <- sysProps) {
+ System.setProperty(key, value)
+ }
+ } else {
+ for ( (key, value) <- sys.env) {
--- End diff --
I commented on this before, but I think it's extremely weird to be mixing
system properties and env variables. They really should be separate parameters
to the `sparkMain` method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
