Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15566#discussion_r84815528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -366,26 +366,10 @@ case class InsertIntoTable(
override def children: Seq[LogicalPlan] = child :: Nil
override def output: Seq[Attribute] = Seq.empty
- lazy val expectedColumns = {
- if (table.output.isEmpty) {
- None
- } else {
- // Note: The parser (visitPartitionSpec in AstBuilder) already turns
- // keys in partition to their lowercase forms.
- val staticPartCols = partition.filter(_._2.isDefined).keySet
- Some(table.output.filterNot(a => staticPartCols.contains(a.name)))
- }
- }
-
assert(overwrite || !ifNotExists)
assert(partition.values.forall(_.nonEmpty) || !ifNotExists)
- override lazy val resolved: Boolean =
- childrenResolved && table.resolved && expectedColumns.forall {
expected =>
- child.output.size == expected.size &&
child.output.zip(expected).forall {
- case (childAttr, tableAttr) =>
- DataType.equalsIgnoreCompatibleNullability(childAttr.dataType,
tableAttr.dataType)
--- End diff --
Why remove these?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
