Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15566#discussion_r84824909
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1363,21 +1377,34 @@ class DDLSuite extends QueryTest with
SharedSQLContext with BeforeAndAfterEach {
assert(catalog.listPartitions(tableIdent).map(_.spec).toSet ==
Set(part1, part2, part3, part4))
}
+
// table to alter does not exist
intercept[AnalysisException] {
sql("ALTER TABLE does_not_exist ADD IF NOT EXISTS PARTITION (a='4',
b='9')")
}
+
// partition to add already exists
intercept[AnalysisException] {
sql("ALTER TABLE tab1 ADD PARTITION (a='4', b='8')")
}
+
+ // partition to add already exists when using IF NOT EXISTS
maybeWrapException(isDatasourceTable) {
sql("ALTER TABLE tab1 ADD IF NOT EXISTS PARTITION (a='4', b='8')")
}
if (!isDatasourceTable) {
assert(catalog.listPartitions(tableIdent).map(_.spec).toSet ==
Set(part1, part2, part3, part4))
}
+
+ // partition spec in ADD PARTITION should be case insensitive by
default
+ maybeWrapException(isDatasourceTable) {
+ sql("ALTER TABLE tab1 ADD PARTITION (A='9', B='9')")
--- End diff --
yea we should, but I'd like to do it in follow-up, as this is a pretty big
change, the created table is used in almost all the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
