Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15566#discussion_r84823617
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala
 ---
    @@ -370,17 +370,6 @@ class InsertIntoHiveTableSuite extends QueryTest with 
TestHiveSingleton with Bef
         assert(cause.getMessage.contains("insertInto() can't be used together 
with partitionBy()."))
       }
     
    -  test("InsertIntoTable#resolved should include dynamic partitions") {
    -    withSQLConf(("hive.exec.dynamic.partition.mode", "nonstrict")) {
    -      sql("CREATE TABLE partitioned (id bigint, data string) PARTITIONED 
BY (part string)")
    -      val data = (1 to 10).map(i => (i.toLong, s"data-$i")).toDF("id", 
"data")
    -
    -      val logical = InsertIntoTable(spark.table("partitioned").logicalPlan,
    -        Map("part" -> None), data.logicalPlan, overwrite = false, 
ifNotExists = false)
    -      assert(!logical.resolved, "Should not resolve: missing partition 
data")
    --- End diff --
    
    Because I removed this logic from `InsertIntoTable.resolved`, see the 
reason [here](https://github.com/apache/spark/pull/15566/files#r84823202)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to