Github user mpjlu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15647#discussion_r85310501
  
    --- Diff: docs/ml-features.md ---
    @@ -1333,14 +1333,14 @@ for more details on the API.
     `ChiSqSelector` stands for Chi-Squared feature selection. It operates on 
labeled data with
     categorical features. ChiSqSelector uses the
     [Chi-Squared test of 
independence](https://en.wikipedia.org/wiki/Chi-squared_test) to decide which
    -features to choose. It supports three selection methods: `KBest`, 
`Percentile` and `FPR`:
    +features to choose. It supports three selection methods: `numTopFeatures`, 
`percentile`, `fpr`:
     
    -* `KBest` chooses the `k` top features according to a chi-squared test. 
This is akin to yielding the features with the most predictive power.
    -* `Percentile` is similar to `KBest` but chooses a fraction of all 
features instead of a fixed number.
    -* `FPR` chooses all features whose false positive rate meets some 
threshold.
    +* `numTopFeatures` chooses the `k` top features according to a chi-squared 
test. This is akin to yielding the features with the most predictive power.
    --- End diff --
    
    Should use k here since KBest is changed to numTopFeatures?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to